Possible bugs in Log File analysis

I followed up on my own question about Bet/Raise and Most Played log statistics. I found a couple of possible minor bugs - please see the post in the General issues forum
ridley97

If Ive read it right, bugs in Most Bet/Raise and Most Played have minimal impact and are easy to fix

---

In this section of function get_most_raise :

01 while($row = $query->fetch(PDO::FETCH_ASSOC)) {
02 if(is_numeric($row) & $row>0 & is_numeric($row) & $row>=0 & $row<=4 & is_numeric($row) & $row>=0 & is_numeric($row) & $row>0 & $row<=10) {
03 if($row != $oldHandID) {
04 for($i=0;$i<count($player_list_seat);$i++) {
05 $most_raise_found_hand[$i] = false;
06 }
07 }
08 if($row=='bets' || ($row=='is all in with' && $row>$oldAmount ) ) {
09 $most_raise[2][$row-1]++;
10 if(!$most_raise_found_hand[$row-1]) {
11 $most_raise[3][$row-1]++;
12 $most_raise_found_hand[$row-1] = true;
13 }
14 }
15 $oldAmount = $row;
16 $oldHandID = $row;
17 }
18 }


Error : Final Bet Amount is carrying forward to next Hand as 'previous bet amount',
so an opening Action of All-In does not count as a raise, unless its higher than final bet of previous hand.


Note line 08 is interpreted as: if (action = bet) OR [ (action = all-in) AND (amount > oldamount) ]
note the [ ] brackets,
so Amount is checked for All-in Actions only.

Fix : Need to reset 'previous bet amount', at the start of each new Hand,
so simply insert one new line, immediately after line 03, as : $oldAmount = -1;

---

In this line of SQL, created within function get_played_hands :

WHERE Amount IS NOT null AND Action<>'posts small blind' AND Action<>'posts big blind' AND UniqueGameID=".$uniqueGameID."

Possible Error : 'Wins' Actions also have not null Amounts, but a big blind could have a 'wins' Action without making a voluntary bet,
either by pre-flop walk, or a sequence of checks to a winning showdown. Should this count as 'played' ?

Fix if required ? : Either append : AND Action<>'wins'to the line
or better, rewrite the line to state explicitly the Actions that do count as voluntary bets, i.e. 'bets', 'calls', 'is all in with'

Note : 'wins (side pot)' Action also has an Amount and may be possible without a voluntary bet against an all-in call less than the small or big blind.